Fix flaky unknown block test - #10001
Merged
mergify[bot] merged 4 commits intoSep 9, 2026
Merged
Conversation
If the EL blob fetch wins the block import race, queued attestations never receive the import notification and attestation_to_unknown_block_processed_after_gossip_block can time out. Reuse the column import notification helper so this path also releases waiting work, including payload attestations after Gloas.
Process the Fulu block without its columns before explicitly fetching blobs from the EL. Assert that the block becomes head and its queued attestation is reprocessed and imported. This deterministically fails when the EL import notification is missing.
michaelsproul
added
test improvement
dknopik
self-requested a review
September 8, 2026 07:51
jimmygchen
reviewed
Sep 8, 2026
| "Block components retrieved from EL" | ||
| ); | ||
| self.chain.recompute_head_at_current_slot().await; | ||
| self.notify_import_after_column(slot, block_root); |
Member
There was a problem hiding this comment.
This also runs for RPC lookups, but the notification helpers log failures with source="gossip". Should we pass the source through so a failed notification after getBlobs isn't reported as gossip?
Member
Author
There was a problem hiding this comment.
good catch, will update!
michaelsproul
added
waiting-on-author
michaelsproul
added
ready-for-review
|
Queued — the merge queue status continues in this comment ↓. |
michaelsproul
added
ready-for-merge
Merge Queue Status
This pull request spent 32 minutes 5 seconds in the queue, including 28 minutes 29 seconds running CI. Required conditions to merge
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix flaky CI test:
attestation_to_unknown_block_processed_after_gossip_blockis flaky #9999Proposed Changes
The test was failing due to a race between importing the block on gossip vs importing the block as a result of its
getBlobscall completing. ThegetBlobscodepath was missing a notification to the reprocess queue, which this PR adds.There's also a new test added which prevents regression on the
getBlobscodepath.Additional Info
Heavily Codex driven, manually reviewed. Change makes sense to me.